fix: prevent extension hang when Claude Code is installed #6550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add detection for Claude Code extension during activation - Implement 30-second timeout protection to prevent hanging - Add graceful error handling with user-friendly messages - Add small delay when Claude Code is detected to prevent race conditions - Refactor activation logic into separate performActivation function Fixes #6548
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| // Show a user-friendly error message | ||
| vscode.window | ||
| .showErrorMessage( | ||
| `Roo Code activation failed. ${claudeCodeExtension ? "This may be due to a conflict with Claude Code extension. " : ""}Please try reloading the window.`, |
Contributor
There was a problem hiding this comment.
User-facing error text here should use i18n translation functions instead of hardcoded strings for consistency.
Suggested change
| `Roo Code activation failed. ${claudeCodeExtension ? "This may be due to a conflict with Claude Code extension. " : ""}Please try reloading the window.`, | |
| t(`Roo Code activation failed. ${claudeCodeExtension ? "This may be due to a conflict with Claude Code extension. " : ""}Please try reloading the window.`), |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| new Promise((_, reject) => setTimeout(() => reject(new Error("Activation timeout")), ACTIVATION_TIMEOUT)), | ||
| ]) | ||
| } catch (error) { | ||
| outputChannel.appendLine(`[Error] Extension activation failed: ${error}`) |
Contributor
There was a problem hiding this comment.
Consider logging detailed error information (e.g., using error.message) to improve debuggability.
Suggested change
| outputChannel.appendLine(`[Error] Extension activation failed: ${error}`) | |
| outputChannel.appendLine(`[Error] Extension activation failed: ${error instanceof Error ? error.message : error}`) |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Reviewing my own code is like debugging in a mirror - everything looks backwards but the bugs are still mine.
Review Summary
Critical Issues:
- Missing test coverage for the new activation logic
Important Suggestions:
- Consider making the 30-second timeout configurable
- The 100ms delay seems arbitrary - could use a more deterministic approach
- Error handling could differentiate between timeout and other failures
Minor Improvements:
- Extract "anthropic.claude-code" to a constant
- Consider adding telemetry for conflict detection
hannesrudolph
added
the
Issue/PR - Triage
Member
|
This doesn't seem to address the root problem, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #6548 where Roo Code would hang on startup when the Claude Code extension is also installed.
Problem
Users reported that after installing Claude Code extension, Roo Code would hang during startup and never reach a usable state. This was caused by a race condition or resource conflict between the two extensions during the activation phase.
Solution
performActivationfunction for better error handlingTesting
Impact
This fix ensures that users can have both Roo Code and Claude Code extensions installed without experiencing startup issues. The timeout protection also provides a general safeguard against any future activation hangs.
Fixes #6548
Important
Fixes Roo Code extension hang by detecting Claude Code, adding a timeout, and improving error handling in
src/extension.ts.activate()to prevent conflicts.activate()to avoid hanging during activation.activate()when Claude Code is detected to prevent race conditions.activate()if activation fails, suggesting window reload.performActivation()for better error handling.activate()to handle activation completion errors without blocking.This description was created by
for b2437a7. You can customize this summary. It will automatically update as commits are pushed.